Audit enhancements #4024
Merged
Audit enhancements #4024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilinPavel
requested changes
Jul 7, 2025
pipe-cli/src/common/audit.py
Outdated
| run_id = os.getenv('RUN_ID') | ||
| if not run_id: | ||
| return '' | ||
| return '[#%s] ' % run_id |
There was a problem hiding this comment.
Wouldn't it be better to explicitly mention that # is a run, like [run_id #< runid >]?
ekazachkova
added a commit
that referenced
this pull request
Jul 10, 2025
* Support run id in audit logs * Support mount event for audit logs * Support run share events for audit logs * cleanup * cleanup (cherry picked from commit cd448d1)
ekazachkova
added a commit
that referenced
this pull request
Jul 10, 2025
* Support run id in audit logs * Support mount event for audit logs * Support run share events for audit logs * cleanup * cleanup (cherry picked from commit cd448d1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #3059
The following changes were added:
[run_id #12345] <message>. The runID shall be added to the audit logs for all PipeCLI commands that are run from Cloud Pipeline instances. To determine run ID theRUN_IDenvironment variable shall be used.MOUNT <mount bucket>.