Prefer for..of loops to forEach for perf #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KurtPreston
commented
Jan 22, 2025
| const execution = fn(payload); | ||
| // Emit errors if fn returns promise that rejects | ||
| (execution as Promise<any>)?.catch?.((e) => { | ||
| if(event === Lifecycle.error) { |
There was a problem hiding this comment.
The only thing I don't like about this PR is the redundancy here. Lines 709-717 are the same as 724-734.
I thought about pulling this error logic into a function to eliminate the redundancy, but I wanted to avoid the overhead of creating a closure when we hit the happy path.
KurtPreston
commented
Jan 22, 2025
src/strongbus_spec.ts
Outdated
| @@ -798,6 +798,22 @@ describe('Strongbus.Bus', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('raises "error" when the listener returns a promise that rejects', async () => { | |||
There was a problem hiding this comment.
This spec is old behavior, but I didn't see it previous captured by a spec.
KurtPreston
commented
Jan 22, 2025
| const error = new Error('Error in callback'); | ||
| bus.on('bar', () => { | ||
| throw error; | ||
| describe('error events', () => { |
There was a problem hiding this comment.
All these new specs are just capturing existing behavior. They all pass against the master branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.