[optimize] Lazy-loaded WordPress inventory #491
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements a “lazy” inventory source, that short-circuits to something simpler the first time it runs. One must call `- meta: refresh_inventory` from a play to get the full (presumably more expensive to compute) inventory. - Detect laziness from a global invocation counter (first run = lazy, second and subsequent runs = “diligent” i.e. full inventory) - Delegate to either ansible.plugins.inventory.script or ansible.plugins.inventory.yaml as directed by configuration
- From wpsible, engage `lazy-wordpress-instances.yml` instead of `wordpress-instances.sh` when in ansible-playbook mode (i.e. laziness won't apply to `wpsible -m raw [...]`) - Refactor ansible/.interactive-playbooks/main.yml to call `- meta: refresh_inventory` iff the tags require that we have a WordPress inventory — Otherwise we stay on the lazy one, i.e. empty `all_wordpresses` group, resulting in `roles/wordpress-instance` being skipped as it previously was
domq
force-pushed
the
master
branch
4 times, most recently
from
89e81dd
to
e8140d7
Compare
domq
force-pushed
the
master
branch
2 times, most recently
from
facec54
to
76d9133
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a “same player shoots again” reincarnation of #434.
Loading the inventory from
wordpress-instances.pytakes some time (or even a long time) because it needs tofind(1)all the sites over NFS. There is already support in the Ansible code base to skiproles/wordpress-instancewhen it can be worked out from the tags that we don't need it; this PR likewise makes sure to skip the useless inventory step.lazy_inventoryinventory plugin, which discriminates between “lazy” and “diligent” modes according to the number of times it runs (i.e. one must runmeta: refresh_inventoryto get the full inventory).interactive-playbooks/main.ymlbefore we runroles/wordpress-instance. If we don't, then theall_wordpressesgroup stays empty (from the “fake” inventory) and therefore the role gets skipped, as it did before