Skip to content

Fixed typos #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Fixed typos #88

merged 2 commits into from
Sep 27, 2024

Conversation

kennethvdberghe
Copy link
Contributor

No description provided.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I was intentional about the HTML extension. I'm talking about adding a loading state that shows up instantly without the need for JavaScript to load. How could we change this to make it more clear?

@kennethvdberghe
Copy link
Contributor Author

I'm not really sure what you mean by that, if I have a look at the files in this exercise, there is no index.html file?

@kentcdodds
Copy link
Member

I'm speaking more generally. The "index.html" file represents the document HTML the server responds with.

@kennethvdberghe
Copy link
Contributor Author

Aha, I see. Not sure how you would change the text to make that more clear. Maybe refering to the rendered HTML instead of the file 'index.html'?

@kentcdodds
Copy link
Member

I think using the words "html document" may help clear things up.

@kennethvdberghe
Copy link
Contributor Author

kennethvdberghe commented Sep 27, 2024 via email

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit d12328a into epicweb-dev:main Sep 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants