-
Notifications
You must be signed in to change notification settings - Fork 381
Fixed typos #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed typos #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. I was intentional about the HTML extension. I'm talking about adding a loading state that shows up instantly without the need for JavaScript to load. How could we change this to make it more clear?
I'm not really sure what you mean by that, if I have a look at the files in this exercise, there is no index.html file? |
I'm speaking more generally. The "index.html" file represents the document HTML the server responds with. |
Aha, I see. Not sure how you would change the text to make that more clear. Maybe refering to the rendered HTML instead of the file 'index.html'? |
I think using the words "html document" may help clear things up. |
Yea, that will prevent users to search for a non-existing file for sure 😃 sorry about the nit-pick, I was just confused.
From: Kent C. Dodds ***@***.***>
Date: Friday, 27 September 2024 at 16:07
To: epicweb-dev/react-suspense ***@***.***>
Cc: Kenneth Van den Berghe ***@***.***>, Author ***@***.***>
Subject: Re: [epicweb-dev/react-suspense] Fixed typos (PR #88)
I think using the words "html document" may help clear things up.
—
Reply to this email directly, view it on GitHub<#88 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AQIGVGEIBI4WXKK2SFHJ6Q3ZYVRARAVCNFSM6AAAAABO6UVDDOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZZGM3DONZRG4>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.