Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix kernel spectral densities #838

Merged
merged 2 commits into from
Oct 24, 2024
Merged

fix kernel spectral densities #838

merged 2 commits into from
Oct 24, 2024

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Oct 24, 2024

Description

This PR closes #837

We'll get there in the end.

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR not done as it's a fix to the previous one.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

@sbfnk sbfnk enabled auto-merge October 24, 2024 11:21
@seabbs
Copy link
Contributor

seabbs commented Oct 24, 2024

(reviewed the maths in the discourse mainly)

@sbfnk sbfnk added this pull request to the merge queue Oct 24, 2024
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 328d6c7 is merged into main:

  • ✔️default: 23s -> 23.4s [-8.38%, +11.53%]
  • ✔️no_delays: 36.8s -> 26.6s [-83.53%, +28.48%]
  • ✔️random_walk: 9.78s -> 9.58s [-9.09%, +5.12%]
  • ✔️stationary: 13.7s -> 13.6s [-14.97%, +12.99%]
  • 🚀uncertain: 41.3s -> 37.8s [-17.12%, -0.12%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

Merged via the queue into main with commit 4c5c7b3 Oct 24, 2024
13 checks passed
@sbfnk sbfnk deleted the fix-kernels branch October 24, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing square in spectral densities
2 participants