Readepi no HIS specific dependencies #80
Open
+3,200
−346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Degoot-AM
requested changes
Jul 5, 2024
There was a problem hiding this comment.
@Karim-Mane, I will review the vignette next week. But in the functions diagram, change read_readcap to read_redcap
R/read_from_servers.R
Outdated
| query <- sprintf("select * from %s", table_name) | ||
| } else if (!is.null(select) && is.null(filter)) { | ||
| # subset all rows and specified columns | ||
| target_columns <- paste(select, collapse = ", ") |
There was a problem hiding this comment.
Suggested change
| target_columns <- paste(select, collapse = ", ") | |
| target_columns <- glue::glue_collapse(select, sep = ", ") |
There was a problem hiding this comment.
Thanks @Degoot-AM - I will update the figure accordingly.
paste() is no longer spotted out by lintr. I think it is better to use paste() and not glue_collapse() to avoid taking {glue} as a dependency.
R/read_from_servers.R
Outdated
| } else { | ||
| # subset specified rows and all columns | ||
| target_columns <- ifelse(!is.null(select), | ||
| paste(select, collapse = ", "), |
There was a problem hiding this comment.
Suggested change
| paste(select, collapse = ", "), | |
| glue::glue_collapse(select, sep = ", ") |
There was a problem hiding this comment.
The same as above applies here too.
… in subsequent queries
Degoot-AM
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes to update the data importing from servers function according to the design vignette.