feat: onboard network edge #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctreatma
commented
Oct 30, 2024
| --- a/spec/services/networkedgev1/oas3.patched/ne-v1-catalog-ne_v1.yaml | ||
| +++ b/spec/services/networkedgev1/oas3.patched/ne-v1-catalog-ne_v1.yaml | ||
| @@ -2487,19 +2487,19 @@ paths: | ||
| type: array |
There was a problem hiding this comment.
NOTE: The specification of the statusList parameter is invalid in the original spec. The enum values need to be defined on the individual string elements, not on the array.
ctreatma
commented
Oct 30, 2024
Comment on lines
6297
to
6302
| accessKey: | ||
| type: string | ||
| example: AKIAIOSFODNN7EXAMPLE | ||
| secretKey: | ||
| type: string | ||
| example: wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY |
There was a problem hiding this comment.
NOTE: I had to change these example values in the fetched and patched spec because the examples in the original spec were being flagged as secrets. I confirmed that the example values in the original spec are not a valid or active access key, but it's better to use example values that are clearly examples. The example values used here were copied from the AWS IAM docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.