-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade openapi-generator to v7.8.0 #21
Conversation
if 'Accept' not in _header_params: | ||
_header_params['Accept'] = self.api_client.select_header_accept( | ||
[ | ||
'application/json' | ||
] | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes in the API classes are a result of OpenAPITools/openapi-generator#19025, which enables overriding the Accept
header
@@ -39,7 +39,7 @@ print(AccessPoint.to_json()) | |||
# convert the object into a dict | |||
access_point_dict = access_point_instance.to_dict() | |||
# create an instance of AccessPoint from a dict | |||
access_point_form_dict = access_point.from_dict(access_point_dict) | |||
access_point_from_dict = AccessPoint.from_dict(access_point_dict) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes in the docs are a result of OpenAPITools/openapi-generator#18359, which fixes invalid code samples in docs.
## Enum | ||
|
||
Name | Type | Description | Notes | ||
------------ | ------------- | ------------- | ------------- | ||
* `COLO` (value: `'COLO'`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These kinds of changes are a result of OpenAPITools/openapi-generator#18804, which includes supported enum values in the docs for enum models
for _item_ntp in self.ntp: | ||
if _item_ntp: | ||
_items.append(_item_ntp.to_dict()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These sorts of changes are a result of OpenAPITools/openapi-generator#19223, which fixes a potential bug when models contain multiple list attributes with different element types.
@equinix/governor-digin-fabric when you have a moment, please review, since most of the changes in this PR are to your service's generated code. I've attempted to annotate the changes, but it's possible I've missed some types of changes. Review of this may require a leap of faith, since the changes are so extensive; from what I've seen they're either non-impacting or they fix issues we would have run into soon enough. @equinix/governor-devrel-engineering you're tagged for review on this because of the changes to:
|
55c461d
to
711979d
Compare
711979d
to
e5056d1
Compare
No description provided.