-
Notifications
You must be signed in to change notification settings - Fork 123
Rename ertserver #12622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Rename ertserver #12622
Conversation
Should not be hardcoded to 120
For clarity and easier testing, prefer singleton global string var over in-place hardcoding of strings.
To not lose test coverage when removing BaseService
This class does not represent a server, but the connection to a server (that it is able to start if needed).
This better exposes this connections class's two modes of operation
This reverts commit 75650f6.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12622 +/- ##
==========================================
+ Coverage 90.54% 90.64% +0.10%
==========================================
Files 435 430 -5
Lines 30043 29773 -270
==========================================
- Hits 27201 26987 -214
+ Misses 2842 2786 -56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
Issue
Resolves #my_issue
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests')When applicable