Skip to content

Conversation

@berland
Copy link
Contributor

@berland berland commented Jan 12, 2026

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

yngve-sk and others added 10 commits January 9, 2026 15:43
Should not be hardcoded to 120
For clarity and easier testing, prefer singleton global string var over in-place hardcoding of strings.
To not lose test coverage when removing BaseService
This class does not represent a server, but the connection to a server (that it
is able to start if needed).
This better exposes this connections class's two modes of operation
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2026

Codecov Report

❌ Patch coverage is 85.62092% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.64%. Comparing base (fcad14a) to head (0908812).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/ert/services/ert_server.py 88.03% 14 Missing ⚠️
src/ert/__main__.py 25.00% 3 Missing ⚠️
src/everest/detached/everserver.py 50.00% 2 Missing ⚠️
src/ert/gui/main.py 50.00% 1 Missing ⚠️
src/ert/shared/storage/connection.py 50.00% 1 Missing ⚠️
src/everest/gui/main_window.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12622      +/-   ##
==========================================
+ Coverage   90.54%   90.64%   +0.10%     
==========================================
  Files         435      430       -5     
  Lines       30043    29773     -270     
==========================================
- Hits        27201    26987     -214     
+ Misses       2842     2786      -56     
Flag Coverage Δ
cli-tests 37.43% <29.71%> (+0.10%) ⬆️
gui-tests 69.14% <73.91%> (+0.52%) ⬆️
performance-and-unit-tests 73.87% <81.04%> (-0.04%) ⬇️
test 38.10% <35.29%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 12, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing berland:rename_ertserver (0908812) with main (87e6aa7)

Summary

✅ 22 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants