Vectorize parameter sampling #12648
Vectorize parameter sampling #12648
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12648 +/- ##
==========================================
- Coverage 90.66% 90.64% -0.02%
==========================================
Files 429 429
Lines 29802 29806 +4
==========================================
- Hits 27019 27018 -1
- Misses 2783 2788 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
achaikou
left a comment
achaikou
left a comment
There was a problem hiding this comment.
I am sorry to crash the party uninvited, but I was out of stuff to do 😊
I am also missing some context in the commit description about the reason for the change (is there some problem to be solved or would code just look nicer?), so I have to guess 😄
| - num_realizations (int): Total number of realizations to generate the | ||
| reproducible sampling. |
There was a problem hiding this comment.
Got somewhat confused by the wording (thinking it was "number of realizations that would be generated").
Taking words from your other comment, maybe something like
Total number of realizations. Assures stable sampling for a given global_seed regardless of currently active realizations.
?
| its sequence, effectively selecting the 'realization'-th sample from the | ||
| distribution. | ||
| - active_realizations (list[int]): indices of the realizations | ||
| to select from the stratified sampling vector; each must satisfy |
There was a problem hiding this comment.
Would vector now always be stratified? From the issue I understood stratifying strategy comes in addition?
Vectorize the sampling rather than drawing one value at a time. This cosmetic change makes the code cleaner and easier to understand. In our view, drawing all samples for a parameter simultaneously is more natural and better aligned with standard sampling APIs (e.g., scipy).
git rebase -i main --exec 'just rapid-tests')When applicable