Skip to content

Conversation

@jonathan-eq
Copy link
Contributor

@jonathan-eq jonathan-eq commented Jan 19, 2026

Issue
Resolves #12527

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@jonathan-eq jonathan-eq added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Jan 19, 2026
@jonathan-eq jonathan-eq self-assigned this Jan 19, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.64%. Comparing base (c528c39) to head (3a94390).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12672      +/-   ##
==========================================
- Coverage   90.67%   90.64%   -0.03%     
==========================================
  Files         429      429              
  Lines       29803    29816      +13     
==========================================
+ Hits        27025    27028       +3     
- Misses       2778     2788      +10     
Flag Coverage Δ
cli-tests 37.55% <0.00%> (-0.02%) ⬇️
gui-tests 69.37% <100.00%> (-0.04%) ⬇️
performance-and-unit-tests 73.89% <0.00%> (-0.03%) ⬇️
test 38.06% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 19, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing jonathan-eq:fix-plotter-bug (3a94390) with main (f0d9de4)

Summary

✅ 22 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport version-18.0 backport version-19.0 release-notes:bug-fix Automatically categorise as bug fix in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in histogram plotter

2 participants