-
Notifications
You must be signed in to change notification settings - Fork 7
fix(app): add landing-page
to union of AppType
#3367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 3397a73 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for a new app type called landing-page
to the AppType union in the fusion-framework module. This change enables the framework to recognize and handle landing page applications in addition to the existing app types.
- Add
landing-page
as a new valid app type in the AppType union - Include appropriate changeset documentation for the patch release
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
packages/modules/app/src/types.ts | Extends AppType union to include 'landing-page' type |
.changeset/cold-rabbits-tickle.md | Adds changeset entry documenting the new app type addition |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This PR modifies the same line as #3386 which has already been merged. The Current state: export type AppType = 'standalone' | 'report' | 'launcher' | 'template' | 'template-app'; This PR needs to:
|
2bb883d
to
747946d
Compare
@odinr ✅ rebase is done. Ready for your review |
747946d
to
aa8fc48
Compare
aa8fc48
to
3397a73
Compare
Coverage Report
File Coverage
|
Why
Used in
fusion-portal
closes:
Check off the following:
Confirm that I checked changes to branch which I am merging into.
Confirm that the I have completed the self-review checklist.
Confirm that my changes meet our code of conduct.