fix(app): add landing-page to union of AppType

[asbjornhaland]

Why

Used in fusion-portal

closes:

Check off the following:

• Confirm that I checked changes to branch which I am merging into.

  • I have validated included files
  • My code does not generate new linting warnings
  • My PR is not a duplicate, check existing pr`s

• Confirm that the I have completed the self-review checklist.

• Confirm that my changes meet our code of conduct.

[changeset-bot]

🦋 Changeset detected

Latest commit: 3397a73

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages

Name	Type
@equinor/fusion-framework-module-app	Patch
@equinor/fusion-framework-app	Patch
@equinor/fusion-framework-react-app	Patch
@equinor/fusion-framework-legacy-interopt	Patch
poc-portal	Patch
@equinor/fusion-framework-cookbook-app-react-ag-grid	Patch
@equinor/fusion-framework-cookbook-app-react-context-custom-error	Patch
@equinor/fusion-framework-cookbook-app-react-context	Patch
@equinor/fusion-framework-cookbook-app-react-feature-flag	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Copilot]

Pull Request Overview

This PR adds support for a new app type called landing-page to the AppType union in the fusion-framework module. This change enables the framework to recognize and handle landing page applications in addition to the existing app types.

• Add landing-page as a new valid app type in the AppType union
• Include appropriate changeset documentation for the patch release

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
packages/modules/app/src/types.ts	Extends AppType union to include 'landing-page' type
.changeset/cold-rabbits-tickle.md	Adds changeset entry documenting the new app type addition

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[odinr]

⚠️ Rebase Required

This PR modifies the same line as #3386 which has already been merged. The AppType union now includes 'template-app' from the merged PR.

Current state:

export type AppType = 'standalone' | 'report' | 'launcher' | 'template' | 'template-app';

This PR needs to:

1. Rebase on latest main
2. Update the union to include both 'template-app' and 'landing-page':

   export type AppType = 'standalone' | 'report' | 'launcher' | 'template' | 'template-app' | 'landing-page';

@asbjornhaland

[asbjornhaland]

@odinr ✅ rebase is done. Ready for your review

[github-actions]

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	6.04%	36813 / 608858
🔵	Statements	6.04%	36813 / 608858
🔵	Functions	44.36%	476 / 1073
🔵	Branches	61.52%	838 / 1362

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/modules/app/src/types.ts	100%	100%	100%	100%

Generated in workflow #10341 for commit 3397a73 by the Vitest Coverage Report Action

[odinr]

✅ Approved

Great work on this PR! The code changes are well-implemented and follow our coding standards.

Highlights

• ✅ Simple and correct union type addition for landing-page app type
• ✅ Proper changeset with appropriate patch versioning
• ✅ All validation passes (build, tests, type checking)
• ✅ Non-breaking change that cleanly extends the AppType union
• ✅ Self-review checklist completed

Code Quality

The implementation is clean and follows TypeScript best practices. Adding 'landing-page' to the AppType union is straightforward and maintains type safety.

Suggestions for Future PRs

For future reference, it would be helpful to include a bit more context in the PR description, such as:

• What landing-page app type represents
• Why this addition is needed
• How it will be used in fusion-portal

This helps reviewers understand the context and purpose of the change, making the review process smoother.

Ready to merge! 🚀

[odinr]

🔧 Admin Testing Complete

This PR has been thoroughly tested by an admin and is ready for merge:

Validation Results

• ✅ Rebase: Successfully rebased onto main
• ✅ Build: Project builds without errors
• ✅ Tests: All tests pass
• ✅ Lint: Code quality checks pass

Admin Actions

• Code reviewed and validated
• Full test suite executed
• Build verification completed
• Linting checks passed

Status: Ready to merge
Reviewer Requirements: Skipped (admin tested)

---

This PR is being merged by admin after comprehensive testing.