Skip to content

Conversation

asbjornhaland
Copy link
Contributor

@asbjornhaland asbjornhaland commented Sep 12, 2025

Why

Used in fusion-portal

closes:

Check off the following:

  • Confirm that I checked changes to branch which I am merging into.

    • I have validated included files
    • My code does not generate new linting warnings
    • My PR is not a duplicate, check existing pr`s
  • Confirm that the I have completed the self-review checklist.

  • Confirm that my changes meet our code of conduct.

@asbjornhaland asbjornhaland self-assigned this Sep 12, 2025
@Copilot Copilot AI review requested due to automatic review settings September 12, 2025 12:47
@asbjornhaland asbjornhaland requested review from odinr and a team as code owners September 12, 2025 12:47
Copy link

changeset-bot bot commented Sep 12, 2025

🦋 Changeset detected

Latest commit: 3397a73

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@equinor/fusion-framework-module-app Patch
@equinor/fusion-framework-app Patch
@equinor/fusion-framework-react-app Patch
@equinor/fusion-framework-legacy-interopt Patch
poc-portal Patch
@equinor/fusion-framework-cookbook-app-react-ag-grid Patch
@equinor/fusion-framework-cookbook-app-react-context-custom-error Patch
@equinor/fusion-framework-cookbook-app-react-context Patch
@equinor/fusion-framework-cookbook-app-react-feature-flag Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for a new app type called landing-page to the AppType union in the fusion-framework module. This change enables the framework to recognize and handle landing page applications in addition to the existing app types.

  • Add landing-page as a new valid app type in the AppType union
  • Include appropriate changeset documentation for the patch release

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/modules/app/src/types.ts Extends AppType union to include 'landing-page' type
.changeset/cold-rabbits-tickle.md Adds changeset entry documenting the new app type addition

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added 🐞 bug Something isn't working 🧬 Modules labels Sep 12, 2025
@odinr
Copy link
Collaborator

odinr commented Sep 16, 2025

⚠️ Rebase Required

This PR modifies the same line as #3386 which has already been merged. The AppType union now includes 'template-app' from the merged PR.

Current state:

export type AppType = 'standalone' | 'report' | 'launcher' | 'template' | 'template-app';

This PR needs to:

  1. Rebase on latest main
  2. Update the union to include both 'template-app' and 'landing-page':
    export type AppType = 'standalone' | 'report' | 'launcher' | 'template' | 'template-app' | 'landing-page';

@asbjornhaland

@asbjornhaland asbjornhaland force-pushed the fix/app/add-landing-page-to-app-type branch from 2bb883d to 747946d Compare September 16, 2025 11:48
@asbjornhaland
Copy link
Contributor Author

@odinr ✅ rebase is done. Ready for your review

@asbjornhaland asbjornhaland force-pushed the fix/app/add-landing-page-to-app-type branch from 747946d to aa8fc48 Compare September 16, 2025 11:50
@odinr odinr force-pushed the fix/app/add-landing-page-to-app-type branch from aa8fc48 to 3397a73 Compare September 17, 2025 10:30
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 6.04% 36813 / 608858
🔵 Statements 6.04% 36813 / 608858
🔵 Functions 44.36% 476 / 1073
🔵 Branches 61.52% 838 / 1362
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/modules/app/src/types.ts 100% 100% 100% 100%
Generated in workflow #10341 for commit 3397a73 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 🧬 Modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants