Skip to content

Stop due to maintenance transitions to wrong state #1047

@andchiind

Description

@andchiind

Describe the bug
Currently many different states transition to stopping_due_to_maintenance, so when the stop request fails, the state machine will not always continue to the correct state. The context for the stopping matters but is lost when this transition occurs. For instance, if we have a paused return home mission, and receive a maintenance mode request, when this stop request fails, we will go to the monitor state.

To Reproduce
Start a return home mission, then try to go to maintenance mode, but fail to stop the mission. It will go to monitor. The same is true if we came from Paused, ReturnHomePaused or Recharging.

Expected behavior
We should either make more precise states for stopping to go to maintenance mode, or we should not make assumptions on what state to transition to when stopping fails, and instead just go to intervention needed. I favour the latter personally.

Screenshots

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions