Use color names in COLOR for bright variants #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the following text with pseudo-escapes: [color bright-red] text [color green] here The word "here" should be regular green and not bright green. By interpreting the escape as bold, it doesn't get cleared the next time a color change occurs. This causes the "here" in the above example to be bright green. This commit changes it so the already defined bright color names in COLORS are used instead, fixing the above issue.
|
Thanks! I noticed that the 100-series non-standard codes had the same problem and fixed that as well. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the following text with pseudo-escapes:
The word "here" should be regular green and not bright green. By interpreting the escape as bold, it doesn't get cleared the next time a color change occurs. This causes the "here" in the above example to be bright green.
This commit changes it so the already defined bright color names in COLORS are used instead, fixing the above issue.