Skip to content

Connect Method #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 23, 2025
Merged

Connect Method #34

merged 4 commits into from
Jan 23, 2025

Conversation

sdc50
Copy link
Member

@sdc50 sdc50 commented Jan 22, 2025

add connect method to manually connect the async client

@sdc50 sdc50 requested a review from araglu January 22, 2025 16:48
@sdc50 sdc50 marked this pull request as draft January 22, 2025 16:52
@sdc50 sdc50 marked this pull request as ready for review January 22, 2025 17:06
araglu
araglu requested changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@araglu araglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. I was a little worried about the function name getting confused with pyuit's connect(), but I can't think of a better name.

After the Black formatting, I found a couple strings that should be combined.

@sdc50 sdc50 merged commit 94f53f2 into main Jan 23, 2025
2 checks passed
@sdc50 sdc50 deleted the connect branch January 23, 2025 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@araglu araglu araglu requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdc50 @araglu