Fix process_results() not calling get_remote_files() #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a job completed, this no longer downloaded remote files because of switching to the AsyncUitClient. This change uses async and await for get_remote_files(). It used to wander into Tethys code with process_results() and _process_results(), so I recreated that in async_process_results(). I also had to await the async_process_results() because it has the @database_sync_to_async decorator. I don't use transfer_intermediate_files, so I have not been able to test that change.
sdc50
reviewed
Feb 11, 2025
sdc50
reviewed
Feb 11, 2025
|
@araglu I think that we should just name the function Possibly a future version of Tethys will support async job functions better and we won't have to override As for |
|
I renamed it to process_results() and removed the unused _safe_process_results(). It works well in my tests. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a job completed, this no longer downloaded remote files because of switching to the AsyncUitClient. This change uses async and await for get_remote_files(). It used to wander into Tethys code with process_results() and _process_results(), so I recreated that in a new function named async_process_results(). I also had to await the async_process_results() because it has the @database_sync_to_async decorator.
I am not that comfortable with async, so I definitely welcome any opinions around that. I am not confident that async_process_results() is a good name.
I don't use transfer_intermediate_files, so I have not been able to test that change.
CHW-680