Implement TPC-H data loader #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ntEgr8
force-pushed
the
tpch-loader
branch
from
8a3e3dd to
be66704
Compare
…ling-simulator into tpch-loader
Draft
sukritkalra
requested changes
Nov 22, 2024
Comment on lines
+1542
to
+1554
| # # Add the TaskGraphRelease events into the system. | ||
| # for task_graph_name, task_graph in self._workload.task_graphs.items(): | ||
| # event = Event( | ||
| # event_type=EventType.TASK_GRAPH_RELEASE, | ||
| # time=task_graph.release_time, | ||
| # task_graph=task_graph_name, | ||
| # ) | ||
| # self._event_queue.add_event(event) | ||
| # self._logger.info( | ||
| # "[%s] Added %s to the event queue.", | ||
| # self._simulator_time.to(EventTime.Unit.US).time, | ||
| # event, | ||
| # ) |
There was a problem hiding this comment.
This should still exist in the Simulator, right?
Comment on lines
+333
to
+340
| # TODO: make configurable | ||
| TPCH_SUBDIR = "100g/" | ||
| DECIMA_TPCH_DIR = ( | ||
| "/home/dgarg39/erdos-scheduling-simulator/profiles/workload/tpch/decima/" | ||
| ) | ||
| CLOUDLAB_TPCH_DIR = ( | ||
| "/home/dgarg39/erdos-scheduling-simulator/profiles/workload/tpch/cloudlab/" | ||
| ) |
There was a problem hiding this comment.
Can you put this in the flags please since this won't work across other machines?
Comment on lines
+343
to
+366
| class SetWithCount(object): | ||
| """ | ||
| allow duplication in set | ||
| """ | ||
|
|
||
| def __init__(self): | ||
| self.set = {} | ||
|
|
||
| def __contains__(self, item): | ||
| return item in self.set | ||
|
|
||
| def add(self, item): | ||
| if item in self.set: | ||
| self.set[item] += 1 | ||
| else: | ||
| self.set[item] = 1 | ||
|
|
||
| def clear(self): | ||
| self.set.clear() | ||
|
|
||
| def remove(self, item): | ||
| self.set[item] -= 1 | ||
| if self.set[item] == 0: | ||
| del self.set[item] |
There was a problem hiding this comment.
Is this doing anything different from collections.Counter?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements a data loader for TPC-H workloads.
The loader is modeled after
data/alibaba_loader.py.The simulator does not correctly handle the addition of
TASK_GRAPH_RELEASEevents when the workload is mutated by the loader. The event handler forTASK_GRAPH_RELEASEis only used for logging, so I just commented out the code that adds the event to the queue, punting a proper fix for later.