Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, i use your repo to do some data type analysis and printed value of most variables in code. I realized that the yaw of Pose could be more than 170 radians. This will not make an accuracy problem but create many unnecessary steps in Dubins::generatePath():line 78
for (int i = 0; i < (ang_end - ang_start) / step; i+=1) {
r_x.push_back(center[0] + cos(ang) * radius);
r_y.push_back(center[1] + sin(ang) * radius);
r_yaw.push_back(yaw);
yaw += step;
ang += step;
}
The calculated yaw will be used hier as variable "ang_end" and this makes the loop to be huge.
I hope I describe the problem clearly to make you understand what I am meaning.
For simulation, i used HybridAStar/hybrid_astar.py. you can try to print the value of "abs(hastar_hp->step_size / rad)" from HybridAStar.cpp and check if the value is bigger than 170 for example, to identify the problem.