Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows build #2

Open
wants to merge 13 commits into
base: release
Choose a base branch
from
Open

Conversation

joshleblanc
Copy link

@joshleblanc joshleblanc commented Mar 31, 2024

These changes are based on the release branch. I'm targeting it back into release so the changes are more visible. I suspect this branch might have been WIP - if you point me in the right direction, I can finish anything missing before targeting master.

Changes:

  • Pinned tauri js dependencies to a version that works without changes
    • note: we can update tauri to latest, we just need the pubkey config, which should be something you guys generate
  • Added missing babel dependencies
  • Changed the browser list to be the same for dev and prod
  • Updated the project path helpers to use platform specific path separators, which fixes a crash on windows when adding a package to a project
  • Updated the kill_process handler to run on both windows and unix
  • Bumped the version
  • There was an issue where nothing could be clicked in the desktop view due to a Dialog from headless UI always being open in the background. Added a workaround, wouldn't say it's a great fix
  • Moved the desktop and mobile navs to their own components
  • Bumped node to v14

Some things I noticed:

  1. Smaug is included in the desktop install, but isn't used. It always looks for a smaug in the path, rather than the smaug that's installed along side it.
  2. Trying to create a project without the smaug cli installed crashes the program (see: 1)
  3. The windows build needs to be built with vs build tools > 2017. Node 14's installed defaults to build tools 2017. Not sure if the windows build is part of the cicd pipeline. I used 2022 to get a working build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant