Enhancement: Add PHPUnit 10/11/12 attribute errors to phpstan baseline #746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PHPUnit\Framework\Attributes\CoversClass attribute is only available in PHPUnit 10+. When running phpstan with PHPUnit 9 installed, these attributes are not recognized, causing static analysis errors. Adding these to the baseline allows CI to pass regardless of which PHPUnit version is installed during static analysis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
PHPUnit\Framework\Attributes\CoversClassattribute errors to the phpstan baseline.Problem
When running
make static-code-analysiswith PHPUnit 9 installed (the default when runningcomposer install), phpstan reports errors for the PHPUnit 10/11/12 test files that use attributes:These errors occur because the
CoversClassattribute was introduced in PHPUnit 10, but phpstan runs against whatever PHPUnit version is installed (typically 9.x based on the platform config).Solution
Regenerated the phpstan baseline to include these expected errors, allowing
make static-code-analysisto pass.Verification
make static-code-analysis # [OK] No errors