fix #38 #40
Merged
fix #38 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When i try with |
|
Nice catch! Seems I really need to do #39 :-p Should be fixed now. (Do you know if we make any attempt to handle right-to-left text?) |
|
Yeap now it seem to work fine! I still sometimes manage to end up with a new line or some extra line when using ctrl-r, but i think it's unrelated to this PR, will file an issue if i can figure who to reproduce. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redrawing the prompt with (*runeBuffer).Print() was leaving the search menu visible. Fix this by clearing to the right of the prompt. This does not regress d9af567, i.e. text to the left of the prompt on the same line is not cleared.
cc @wader