Unbreak rune filtering functionality#61
Conversation
Currently, the rune filtering functionality does not work since the check assumes that the reading of runes fails, which is incorrect in most circumstances when the FilterRunes function is called. This patch flips the condition so that instead evaluates to true instead. Signed-off-by: Sohom <[email protected]>
|
Thanks! |
|
I'm just curious, what's your use case for this functionality? I'd like to get a better sense of how people are using the library. |
My immediate use case is to slim down https://github.com/sohomdatta1/promptui :) It appears that the upstream for that library is unmaintained and I want to update it and fix a few bugs since I depend on it for a few hobby projects :) |
|
Nice :-) What I meant was, what are you using |
The original library used |
|
If I understand the problem statement correctly, it seems like you can accomplish this by processing the return value of |
|
@sohomdatta1 I just wanted to check in about this again? |
Currently, the rune filtering functionality does not work since the check assumes that the reading of runes fails, which is incorrect in most circumstances when the FilterRunes function is called.
This patch flips the condition so that instead evaluates to true instead.