Prototype implementation of using linear regular expressions #2129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... when available Using a dedicated package I created for transparently creating regular expressions with the `l` flag (when available). This requires some refactoring to avoid significant performance overhead by pre- initializing the regular expressions in a closure which can than reuse it for repeated escaping. For this proof of concept I just implemented it for one of the escape modules. Also, it is not tested yet as I did not figure out a way to run AVA tests with the `--enable-experimental-regexp-engine` flag.
ericcornelissen
added
dependencies
github-actions
bot
added
test
This comment was marked as spam.
This comment was marked as spam.
ericcornelissen
commented
Aug 21, 2025
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
|
Currently (as of 7a1ffc7) integration tests fail because |
This comment was marked as spam.
This comment was marked as spam.
ericcornelissen
removed
test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #2122
Summary
Using a dedicated package I created for transparently creating regular expressions with the
lflag (when available). This requires some refactoring to avoid significant performance overhead by pre-initializing the regular expressions in a closure which can than reuse it for repeated escaping.For this proof of concept I just implemented it for one of the escape modules. Also, it is not tested yet as I did not figure out a way to run AVA tests with the
--enable-experimental-regexp-engineflag.