-
Notifications
You must be signed in to change notification settings - Fork 10
Bump @eslint/markdown from 7.2.0 to 7.4.1 #2213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump @eslint/markdown from 7.2.0 to 7.4.1 #2213
Conversation
Bumps [@eslint/markdown](https://github.com/eslint/markdown) from 7.2.0 to 7.4.1. - [Release notes](https://github.com/eslint/markdown/releases) - [Changelog](https://github.com/eslint/markdown/blob/main/CHANGELOG.md) - [Commits](eslint/markdown@v7.2.0...v7.4.1) --- updated-dependencies: - dependency-name: "@eslint/markdown" dependency-version: 7.4.1 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Needs ReviewI recommend reviewing this upgrade before merging because the new package requires Node.js 18.18.0 or higher, which conflicts with the project's stated Node.js engine requirements that include versions 14.18.0, 16.13.0, and 19.x. While this is a devDependency affecting only the development toolchain, the project's CI pipeline still tests against these older Node versions and developers using Node 14, 16, or 19 will be unable to run npm install. The upgrade includes 5 new features and 2 bug fixes as part of ESLint's official markdown support initiative. What we checked
Dependency UsageBased on my search, the package is used in the project's build toolchain to enable code quality enforcement across documentation files. The ESLint configuration imports the markdown plugin and applies it through the processor configuration at line 1293, extending linting coverage to JavaScript code snippets embedded within Markdown documentation throughout the repository. This ensures consistent code quality standards between production code and documentation examples, supporting the library's developer experience and documentation accuracy as a shell escaping utility.
Other Usages (1)These usages were analyzed but no breaking changes were detected: @eslint/markdown
ChangesThis update to @eslint/markdown fixes two bugs (type errors and backslash handling) and adds five new features including a new
View 15 more changes
References (6)[1]: Project declares support for Node.js ^14.18.0 || ^16.13.0 || ^18 || ^19 || ^20 || ^22 || ^24, which includes versions incompatible with the new dependency Line 42 in 143ad37
[2]: New @eslint/markdown@7.4.1 requires Node.js ^18.18.0 || ^20.9.0 || >=21.1.0, dropping support for Node 14.x, 16.x, and 19.x Line 937 in 143ad37
[3]: CI test matrix includes Node 14.18.0 and 16.13.0, which will fail npm clean-install with the new dependency requirements shescape/.github/workflows/checks.yml Line 173 in 143ad37
[4]: @eslint/markdown is a devDependency used in the linting toolchain, not affecting runtime compatibility of the published package Line 68 in 143ad37
[5]: Package is imported and used for linting markdown files in the project's ESLint configuration Line 5 in 143ad37
[6]: ESLint officially supports @eslint/markdown as the next generation of eslint-plugin-markdown with improved parsing and rules (source link) fossabot analyzed this PR using static analysis and dependency research. |
|
Here's the code health analysis summary for commits Analysis Summary
|
Bumps @eslint/markdown from 7.2.0 to 7.4.1.
Release notes
Sourced from
@eslint/markdown's releases.Changelog
Sourced from
@eslint/markdown's changelog.Commits
e354f98chore: release 7.4.1 🚀 (#556)20e88fefix: handle CR in rules to follow CommonMark spec (#493)0d01b19docs: add migration docs (#559)6d1bd73ci: centralizeci-bun.yml(#563)e7c5868ci: add Node.js 25 toci.ymland fix Bun CI (#562)868153bci: resolve failure in therelease-please.ymlworkflow (#558)c95c017docs: Update README sponsors6c88ae1ci: Switch to trusted publishing (#557)d1ad828fix: handle CR inMarkdownSourceCodeand Front Matter util (#554)8992a4drefactor: replacefindOffsetshelper with native methods (#536)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)