Rewrite Git history - Dev Branch #614
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stupid merge conflict from yesterday
Update sp_QuickieStore.sql
tidying up declared and dynamic sql endings
Update sp_QuickieStore.sql
they 2 short
trying to add a dedupe_only mode to index cleanup, if someone wants to not trigger a bunch of unused index disable commands and just dedupe existing indexes. this makes sense for servers that aren't up for a long time, and for people who (rightfully) may not trust usage details.
allow users to filter to only tables in a specific schema
well that was silly of me
…han a variable. This closes erikdarlingdata#576. In particular, the filter now works at the query level rather than the plan level. Because this temp table is references by @where_clause, we no longer need @having_clause. Given that @where_clause is used by almost everything, we can now be much more confident that filtering by @execution_count works properly everywhere.
Made filtering by @execution_count be done with a temp table rather than a variable
sp_QuickieStore: Appended _ms where it was missing for avg_cpu_time
… it's much better than the bugs that come with relying on @sort_order to populate @ColumnDefinitions before you have validated @sort_order. Since this change was to close erikdarlingdata#601, I have made all checks of if sort order is a wait be done by the @sort_order_is_a_wait variable. This is how we did it before 5.1.
sp_QuickieStore: Moved validation of @sort_order to be much earlier on.
…t before avg_query_duration_ms. Closes erikdarlingdata#603.
sp_QuickieStore: Moved special sorting columns for special sort order values to be jus…
This closes erikdarlingdata#605 on the assumption that it is a documentation issue.
… filtering them out is passed in.
…when-filtering-out sp_QuickieStore: Made plan hash, query hash, or sql handle show when the parameter for filtering them out is passed in
sp_QuickieStore: Documents that @format_output = 1 removes most decimals.
Adding support for indexed views in addition to indexes on tables.
…e build up the table variable. Fixes erikdarlingdata#611 and is very similar to erikdarlingdata#602.
…on-validation-to-just-after-sort-order sp_QuickieStore: Move regression validation to just after sort order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #613 in Dev. It is correct that this appears to be a huge commit... I think.
On reflection, it may be safer for Erik himself to follow the instructions I've placed on the issue.