Made sp_HumanEventsBlockViewer not error out when system_health is used #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed. Updated documentation, printing, and debug output to reflect this. Also automatically selected event_file if no target type is specified for system_health, since our usual default of table is no good. Closes erikdarlingdata#617.
…g it because we are using system_health
…. This means that we duplicate some logic when checking if we are using system_health.
Contributor
Author
|
@erikdarlingdata Better? |
Contributor
Author
|
@erikdarlingdata Does reading system_health from the ring buffer actually work? I can't see where the logic for it is and I'm suspiciously seeing the same results no matter what non-NULL If it doesn't, then I don't trust my XPath enough to fix it. |
Owner
|
@ReeceGoding mobile at the moment so I can’t look at everything, but reading system health from the ring buffer does work. It’s the only way I can get anything at all on Managed Instance (SQL Database doesn’t have system health). |
Contributor
Author
|
@erikdarlingdata Interesting. As far as I can tell, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated documentation, printing, and debug output to reflect this. Also automatically selected event_file if no target type is specified for system_health, since our usual default of table is no good. Closes #617.
I'm pretty sure this my first PR to
sp_HumanEventsBlockViewerso be suspicious.