Dev #619
Merged
Dev #619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sp_QuickieStore: Appended _ms where it was missing for avg_cpu_time
… it's much better than the bugs that come with relying on @sort_order to populate @ColumnDefinitions before you have validated @sort_order. Since this change was to close #601, I have made all checks of if sort order is a wait be done by the @sort_order_is_a_wait variable. This is how we did it before 5.1.
sp_QuickieStore: Moved validation of @sort_order to be much earlier on.
…t before avg_query_duration_ms. Closes #603.
sp_QuickieStore: Moved special sorting columns for special sort order values to be jus…
This closes #605 on the assumption that it is a documentation issue.
… filtering them out is passed in.
sp_QuickieStore: Made plan hash, query hash, or sql handle show when the parameter for filtering them out is passed in
sp_QuickieStore: Documents that @format_output = 1 removes most decimals.
Adding support for indexed views in addition to indexes on tables.
…o-just-after-sort-order sp_QuickieStore: Move regression validation to just after sort order
…ed. Updated documentation, printing, and debug output to reflect this. Also automatically selected event_file if no target type is specified for system_health, since our usual default of table is no good. Closes #617.
…g it because we are using system_health
…. This means that we duplicate some logic when checking if we are using system_health.
Made sp_HumanEventsBlockViewer not error out when system_health is used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.