Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to define onUpdateInput callback same as on original AutoComplete component #158

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adam187
Copy link

@adam187 adam187 commented Jun 25, 2017

Original AutoComplete allows you to define onUpdateInput callback which is triggered when input value changes. For example to fetch remote data based on value and update dataSource with it.

This change allows to do same on this AutoComplete component. It will also bypass rest of arguments to have same signature as in original component function(searchText: string, dataSource: array, params: object) => void

@codecov-io
Copy link

codecov-io commented Jun 25, 2017

Codecov Report

Merging #158 into master will increase coverage by 6.18%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #158      +/-   ##
=========================================
+ Coverage   76.31%   82.5%   +6.18%     
=========================================
  Files          11      11              
  Lines          38      40       +2     
=========================================
+ Hits           29      33       +4     
+ Misses          9       7       -2
Impacted Files Coverage Δ
src/AutoComplete.js 77.77% <100%> (+34.92%) ⬆️
src/Slider.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b26f161...9045cfd. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants