Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ERL_SYS_SHELL env variable to point to system shell for os:cmd() #8972

Open
wants to merge 7 commits into
base: maint
Choose a base branch
from
Open

Add the ERL_SYS_SHELL env variable to point to system shell for os:cmd() #8972

wants to merge 7 commits into from

Commits on Oct 24, 2024

  1. Add the os_cmd_shell kernel config parameter to point to system shell… 

    … for os:cmd/2

Initialize the parameter at startup

Fix the test - restore the old shell after the test
Add initialization to other tests that use os:cmd/2
Update os:cmd/2 description
    @yarisx
    yarisx committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    7af29a1 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Lukas Backström (FKA Larsson) <[email protected]>
    @yarisx @garazdawi
    yarisx and garazdawi authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    98e2413 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Revert addition of os:internal_init_cmd_shell() to tests

    @yarisx
    yarisx committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    ebb9956 View commit details
    Browse the repository at this point in the history

  2. Add a test to check setting the new config parameter at startup

    @yarisx
    yarisx committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    5280771 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Lukas Backström (FKA Larsson) <[email protected]>
    @yarisx @garazdawi
    yarisx and garazdawi authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    4d609e3 View commit details
    Browse the repository at this point in the history

  4. kernel: Re-init shell when config is changed.

    @garazdawi
    garazdawi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    9b9992d View commit details
    Browse the repository at this point in the history

  5. kernel: Use persistent term to store os_cmd_shell value 

    This has two purposes:

1. Make it impossible to change the value through the application:set_env API.
2. Make the lookup slightly faster.
    @garazdawi
    garazdawi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    bb27085 View commit details
    Browse the repository at this point in the history