Combine memory statistics into a single metric with labels #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Combine memory statistics into a single metric with labels. Additionally, now we are tracking PSS, which provides a more accurate representation of how much physical memory is uniquely and proportionally used by a process, especially in systems where many processes share memory.
Why
However, a single metric is enough to track the three key metrics for each worker: RSS, PSS, and Shared Memory. Pitchfork utilizes
/proc/[pid]/smaps_rollup
to report these values.Anything else
/proc/[pid]/smaps_rollup
reports its metrics to kilobytes, I'm adding bytes sufix to the metric name