Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine memory statistics into a single metric with labels #70

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

robertomiranda
Copy link
Collaborator

What

Combine memory statistics into a single metric with labels. Additionally, now we are tracking PSS, which provides a more accurate representation of how much physical memory is uniquely and proportionally used by a process, especially in systems where many processes share memory.

Why

However, a single metric is enough to track the three key metrics for each worker: RSS, PSS, and Shared Memory. Pitchfork utilizes /proc/[pid]/smaps_rollup to report these values.

Anything else

/proc/[pid]/smaps_rollup reports its metrics to kilobytes, I'm adding bytes sufix to the metric name

@robertomiranda robertomiranda marked this pull request as ready for review September 20, 2024 12:18
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6442f72) to head (4669448).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #70   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           38        38           
  Lines          854       852    -2     
=========================================
- Hits           854       852    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@errm errm merged commit a98c51e into master Sep 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants