Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix popup showing when highlighting #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eranhirs
Copy link

@eranhirs eranhirs commented Nov 9, 2023

Following issues #16, #28 and welpdx#3

@eranhirs
Copy link
Author

eranhirs commented Nov 9, 2023

Until something like this pull request is merged, if someone wants to use this you can clone my fork, change to the branch fix_popup, and run the bin/build.sh file. This will create an .xpi file that you can use.

@FrLars21
Copy link

FrLars21 commented Nov 11, 2023

@eranhirs I just refactored this plugin to work with Zotero 7, while also adding a lot of enhancements (better error messages, custom "citation count" column etc.). Since this repo seems unmaintained and because Zotero 7 bootstrapped plugins are fundamentally different, the code is hosted here. Would you care to submit a PR to that project with this bugfix, so that you can be properly credited?

Copy link

@njursi njursi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update to the latest xpi file, thank you very much

@eschnett
Copy link
Owner

@eranhirs I am not putting enough time into maintaining this repository. Are you interested in becoming a collaborator so that you can merge PRs yourself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants