-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use 'files' instead of .npmignore #244
base: main
Are you sure you want to change the base?
Conversation
This looks good to me if you want to first resolve the conflicts, however. |
package.json
Outdated
@@ -16,6 +16,10 @@ | |||
"repository": "https://github.com/xjamundx/eslint-plugin-promise", | |||
"homepage": "https://github.com/xjamundx/eslint-plugin-promise", | |||
"bugs": "https://github.com/xjamundx/eslint-plugin-promise/issues", | |||
"main": "index.js", | |||
"files": [ | |||
"rules" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"rules" | |
"rules/**/*.js", | |
"index.js" |
I would go with this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that would miss rules/lib/is-member-call-with-object-name which perhaps does want to end with .js?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sorry, that does want to end with .js
. Addressed in the TypeScript PR, but I can supply a separate PR to address.
c9c7922
to
5ced6af
Compare
I've redone the changes on the tip of If you add TypeScript types, you'll also want to add Except the previously mentioned file lacking |
What is the purpose of this pull request?
What changes did you make? (Give an overview)
Change build to use
files
over.npmignore
..npmignore
lists the files that should not be in the build, and can easily go out of date (and has) because it needs updating every time a file is added that shouldn't be in the build.files
inpackage.json
lists the files that should be in the build, and can be kept up to date more easily.I include the
rules
folder, and the files which are always included automatically.