Skip to content

Fix language in Attribute deprecation statement #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2025

Conversation

theurich
Copy link
Member

This PR replaces the specific 9.0.0 target with more vague language to be consistent with next release being 9.0.0, and Attribute work is not scheduled.

a more vague formulation about future ESMF release.
Copy link
Member

@uturuncoglu uturuncoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@billsacks
Copy link
Member

billsacks commented Jul 10, 2025

Copying an email to here:

What about changing "is scheduled for removal with" -> "will be removed in"? I think that works with either something specific ("will be removed in ESMF 9.0.0") or something more vague ("will be removed in a future release").

But I'm also fine with just sticking with what you have here.

@theurich
Copy link
Member Author

Copying an email to here:

What about changing "is scheduled for removal with" -> "will be removed in"? I think that works with either something specific ("will be removed in ESMF 9.0.0") or something more vague ("will be removed in a future release").

But I'm also fine with just sticking with what you have here.

I like your suggestion wrt wording ... will update push the change under this PR.

Copy link
Member

@billsacks billsacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for thinking of this and making this change!

@theurich theurich merged commit ed65a0e into develop Jul 10, 2025
8 checks passed
@theurich theurich deleted the fix/attribute-deprecation branch July 10, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants