src: Fix division by zero in UDP bandwidth calculation in iperf_api.c#1906
Merged
bmah888 merged 1 commit intoesnet:masterfrom Aug 1, 2025
Merged
Conversation
In iperf_api.c, variables sender_time and receiver_time were used as denominators in bandwidth calculations without a zero check, which could lead to division by zero and undefined behavior. To fix this, introduced sent_bandwidth and recv_bandwidth variables with a conditional check to prevent division by zero. If time is zero, bandwidth is now safely set to 0.0. Signed-off-by: Anton Moryakov <[email protected]>
bmah888
approved these changes
Aug 1, 2025
Contributor
bmah888
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE NOTE the following text from the iperf3 license. Submitting a
pull request to the iperf3 repository constitutes "[making]
Enhancements available...publicly":
The complete iperf3 license is available in the
LICENSEfile in thetop directory of the iperf3 source tree.
Version of iperf3 (or development branch, such as
masteror3.1-STABLE) to which this pull request applies:masterBrief description of code changes (suitable for use as a commit message):