Skip to content

#186 #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 9, 2025
Merged

#186 #188

merged 10 commits into from
Apr 9, 2025

Conversation

sunami09
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@juztas juztas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove breaks

@sunami09 sunami09 requested a review from juztas March 25, 2025 06:45
@@ -326,6 +326,8 @@ def addRowPanel(self, row, panels, recordAnnotations=False):
if not row['collapsed']:
out.append(row)
for pan in panels:
if pan['title'] == 'Network Address Information':
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not do this inside the code. I would remove all Network Address Information template. Why we want to keep it if we are not using it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that but it didn't work.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can show you in tomorrow's meeting

added = []
hostnum, switchnum = 1, 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look at enumerate and use only 1 index from a list. No need separate numbers for hostnum, switchnum

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets say I have [host, host, host, switch] will it not create
host1
host2
host3
and switch4?

but we want hostt1, host2, host3, switch1 right?

Copy link
Collaborator

@juztas juztas Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we want it in a flow:
host1, switch2, switch3, switch4, host5


if len(diagrams) > 1:
self.generated['panels'] += diagrams[1]
if self.config.get('Debug', True):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need documentation inside config file

@juztas juztas merged commit 22a16c9 into main Apr 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants