refactor(esp-hal-buzzer): Enable playing tones from slices instead of fixed-size arrays #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
You'll need to rebase this one I'm afraid. |
AnthonyGrondin
force-pushed
the
feat/play-from-slices
branch
from
e94d753 to
9d7eb66
Compare
…f fixed-size arrays - Add new `Buzzer::play_tones_from_slice(&mut self, sequence: &[u32], timings: &[u32])` to play tones from slices. BREAKING CHANGE: `Buzzer::play_song()` now takes a slice instead of a fixed-size array
AnthonyGrondin
force-pushed
the
feat/play-from-slices
branch
from
9d7eb66 to
b497adf
Compare
Collaborator
Author
|
I updated the aliases and features to reflect unstability |
bugadani
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buzzer::play_tones_from_slice(&mut self, sequence: &[u32], timings: &[u32])to play tones from slices.Buzzer::play_song()now takes a slice instead of a fixed-size array.