esp-radio: Use types from esp_hal::time where appropriate
#4835
+20
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JurajSadel
changed the title
esp_hal::time where appropriate
MabezDev
reviewed
Jan 22, 2026
| channel: (*rx_cntl).channel(), | ||
| secondary_channel: SecondaryChannel::from_raw((*rx_cntl).secondary_channel()), | ||
| timestamp: Duration::from_micros((*rx_cntl).timestamp().into()), | ||
| timestamp: Instant::EPOCH + Duration::from_micros((*rx_cntl).timestamp() as u64), |
Member
There was a problem hiding this comment.
Isn't this already a timestamp, why are we now adding EPOCH to it?
Contributor
Author
There was a problem hiding this comment.
I think we want to have an Instant instead of Duration for the timestamp fields - and with this way we can return an Instant. Maybe there is a more elegant way?
EDIT: And EPOCH is pub const EPOCH: Instant = Instant(InnerInstant::from_ticks(0)); so it should be the same.
Contributor
There was a problem hiding this comment.
Seems it's just because there is no way to "just create" an Instant?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't address points 1, 4, and 5 from the issue as I don't think it's a correct thing to do.
closes #4832