-
Notifications
You must be signed in to change notification settings - Fork 389
If a cherrypick fails, PR with the conflicts for manual intervention #4853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates the backport workflow so that a backport PR is still created even when the cherry-pick results in conflicts, enabling manual intervention via a draft conflicts commit.
Changes:
- Configure
korthout/backport-actionto use the experimentaldraft_commit_conflictsconflict resolution mode.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Skip doesn't seem to work in the merge queue, cc @JurajSadel any ideas? |
|
We keep making the same mistake with labels and merge queues. Maybe we need a reusable workflow that can make them work |
I missed #4586 (comment) but luckily @bugadani caught it. This PR changes the backlog action to create the PR regardless of cherry pick success.