-
Notifications
You must be signed in to change notification settings - Fork 211
Followup for adding support for deep and light sleep #555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
will squash later
|
Changes made:
Changes not done:
Changes that I would like to do:
|
|
If you want the CI to succeed, you might want to put #![allow(unknown_lints)]
#![allow(unexpected_cfgs)]at the top of your example. And then look at the remaining Clippy errors. But it would be good to fix the CI before requesting a review. I'll be able to review mid/late next week (on travel ATM). |
|
Yeah.. no I was wondering why the CI was failing myself, (the feature flags used weren't anything new and not present in the codebase), I'll fix the remaining errors and make sure CI is passing before the next review. |
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo fmtcommand to ensure that all changed code is formatted correctly.cargo clippycommand to ensure that all changed code passes latest Clippy nightly lints.CHANGELOG.mdin the proper section.Pull Request Details 📖
Description
Please provide a clear and concise description of your changes, including the motivation behind these changes. The context is crucial for the reviewers.
Testing
Describe how you tested your changes.