Skip to content

Conversation

@mdwn
Copy link
Contributor

@mdwn mdwn commented Jan 4, 2026

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo fmt command to ensure that all changed code is formatted correctly.
  • I have used cargo clippy command to ensure that all changed code passes latest Clippy nightly lints.
  • My changes were added to the CHANGELOG.md in the proper section.

Pull Request Details 📖

Description

The esp32p4 doesn't have a radio, so the modem peripheral has been removed for esp32p4.

Testing

Compiled against the esp32p4. trying to access modem:

    let peripherals = esp_idf_svc::hal::peripherals::Peripherals::take().unwrap();
    peripherals.modem.power_on();
error[E0609]: no field `modem` on type `Peripherals`
  --> src/main.rs:28:17
   |
28 |     peripherals.modem.power_on();
   |                 ^^^^^ unknown field
   |
   = note: available fields are: `pins`, `uart0`, `uart1`, `i2c0`, `i2c1` ... and 12 others

For more information about this error, try `rustc --explain E0609`.
error: could not compile `osc-pedal` (bin "osc-pedal") due to 1 previous error

@ivmarkov
Copy link
Collaborator

ivmarkov commented Jan 4, 2026

Thanks!

@ivmarkov ivmarkov merged commit f9691a3 into esp-rs:master Jan 4, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants