Build with clang by default #99
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #98
Turns out, inventing a generic, cross-platform "sysroot" for
clang+esp-mbedtlsis so simple, that it does not make any sense to compile with GCC by default, and thus ask users to install the (cross) GCC toolchain for their target.This suddenly makes on-the-fly compilation of esp-mbedtls so much eaiser!
We can just tell users: "install your system clang"*.
(*)
Caveat 1: System clang (
sudo apt-get install clang) won't work for xtensa targets until after upstream llvm (and thus clang) get support for thextensatargets. But in the meantime,espupwould do.Caveat 2: Users would also need
cmake+ninjapre-installed. For now. But this is also no big deal.It would have been so nice to have
rustupdistributeclangas well, but it seems this effort had died: rust-lang/rust#56371