-
Notifications
You must be signed in to change notification settings - Fork 149
Use esp-hal runners for HIL #996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
1c7fcd9
5355173
46e9d0b
b3a5631
f427e47
89ea165
0cd913b
8c1fa44
cf3b0ae
4a7126b
afc7903
2ed3760
7a88ebb
dfe9b8b
d0e9c7a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure if this is the best way, and I guess this could supersede probe-rs udev rules in the runner (https://github.com/esp-rs/esp-hal/tree/main/hil-test#rpi-setup), but having the symlink to I only tested this locally, I haven't yet added this file to the runners, I'll wait for some input before
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I like this a lot! We should use these symlinks on all runners if possible. Regarding the use rules, I think we still need both but we can put both in the udev rules directory.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, the comment was outdated, all the runners already have this udev rules settled, we are using both probe-rs and this ones, but since this is |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Copy this file to /etc/udev/rules.d/ | ||
| # If rules fail to reload automatically, you can refresh udev rules | ||
| # with the command "udevadm control --reload" | ||
|
|
||
| # This rules are based on the udev rules from the OpenOCD project, with unsupported probes removed. | ||
| # See http://openocd.org/ for more details. | ||
| # | ||
| # This file is available under the GNU General Public License v2.0 | ||
|
|
||
| ACTION!="add|change", GOTO="espflash_rules_end" | ||
|
|
||
| SUBSYSTEM=="gpio", MODE="0660", GROUP="plugdev", TAG+="uaccess" | ||
|
|
||
| SUBSYSTEM!="usb|tty|hidraw", GOTO="espflash_rules_end" | ||
|
|
||
| # Please keep this list sorted by VID:PID | ||
|
|
||
| # Espressif USB JTAG/serial debug unit and USB Bridge | ||
| ATTRS{idVendor}=="303a", ATTRS{idProduct}=="1001", MODE="660", GROUP="plugdev", TAG+="uaccess", SYMLINK+="serial_ports/usb" | ||
| ATTRS{idVendor}=="303a", ATTRS{idProduct}=="1002", MODE="660", GROUP="plugdev", TAG+="uaccess", SYMLINK+="serial_ports/usb" | ||
| # Silicon Labs CP210x UART Bridge | ||
| ATTRS{idVendor}=="10c4", ATTRS{idProduct}=="ea60", GROUP="plugdev", MODE="660", TAG+="uaccess", SYMLINK+="serial_ports/uart" | ||
|
|
||
| LABEL="espflash_rules_end" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could duplicate a bit of code to speed things up, and only wait for the packages of their arch to be finished, not sure if its worth though