-
Notifications
You must be signed in to change notification settings - Fork 149
Use esp-hal runners for HIL #996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
98374ea to
7605974
Compare
7c1ab00 to
49b7347
Compare
49b7347 to
1c7fcd9
Compare
70e3b0e to
2462b3b
Compare
60adc41 to
4c545a5
Compare
| ] | ||
|
|
||
| name: HIL | ${{ matrix.target.soc }} | ||
| needs: build-packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could duplicate a bit of code to speed things up, and only wait for the packages of their arch to be finished, not sure if its worth though
4c545a5 to
d87d2d9
Compare
d87d2d9 to
b3a5631
Compare
a7ccf75 to
f427e47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is the best way, and I guess this could supersede probe-rs udev rules in the runner (https://github.com/esp-rs/esp-hal/tree/main/hil-test#rpi-setup), but having the symlink to /dev/serial_ports/usb and /dev/serial_ports/uart is quite useful I think.
I only tested this locally, I haven't yet added this file to the runners, I'll wait for some input before
6666134 to
0cd913b
Compare
1eaf197 to
cf3b0ae
Compare
8a87f06 to
4a7126b
Compare
d368cbf to
afc7903
Compare
473f5a4 to
2ed3760
Compare
d7b3fdf to
2441b23
Compare
2441b23 to
d0e9c7a
Compare
This PR does a few things:
test_list_portsto also accept USB Serial/Jtag portsUSBandUARTports when possibleudevrule that symlinks devices to/dev/serial_ports/uartand/dev/serial_ports/usbHIL CI Run: https://github.com/esp-rs/espflash/actions/runs/21246847880
Pending things: