Skip to content

Conversation

@SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Nov 18, 2025

Brief explanation of every project:

  • part1: Read sensor values and prints them
  • part2: Connects to wifi using env variables and does an http request
  • part3: Creates an AP and wifi provisioning portal, once you enter the credentials on the portal it does an http request
  • part4: Reads the sensor values and send them via mqtt (it doesnt have wifi provisioning)
  • part5: Like part4 but with wifi provisioning
  • part6: Adds a small ota example to part5

@bjoernQ
Copy link
Contributor

bjoernQ commented Nov 18, 2025

Awesome! Thanks for all the effort

I think I would change a few things

  • part1: Read sensor values and prints them
  • part2: Connects to wifi using env variables and does an http request => maybe use an http library like edge-http or reqwless to make things a bit simpler - manual http is a lot of noise
  • part3: Creates an AP and wifi provisioning portal, once you enter the credentials on the portal it does an http request => I would move this to part5 (well it's there but maybe just leave this part out, might be confusion at this point)
  • part4: Reads the sensor values and send them via mqtt (it doesnt have wifi provisioning)
  • part5: Like part4 but with wifi provisioning
  • part6: Adds a small ota example to part5

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'll probably take a few iterations on this, but this is some initial feedback for you to address :)

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was also going to recommend getting rid of lib.rs, but looks like @MabezDev beat me to it. To build on this though, we should just move src/bin/main.rs to src/main.rs for each project to simplify the directory structure a bit, and then we can remove the [[bin]] sections from each Cargo manifest as well.

Additionally:

  • Do we want to de-duplicate .gitignore and just move it to the root or something?
  • Do we want to use a Cargo workspace so we can avoid duplicating the configuration for each part?

Still have more reviewing to do, will likely have more comments 😅

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it's looking good!

I think my only comment now would be about the module/task structure of the tasks leading up to part 6. I'm really pleased with how everything looks in part6, I think we should make modularization and splitting things into its own task(s) part of all parts except for part 1 (just because its so simple).

I want the focus of main.rs to be on the new content we're trying to teach in the current part, there's a lot of noise in some of these parts because previous parts are all loaded into main.rs.

After that's complete, I think I'm happy to approve this on my side!

@SergioGasquez SergioGasquez marked this pull request as ready for review December 12, 2025 08:56
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your continued effort here. I think this is looking great!

LGTM, I think this is more than enough to start thinking about the write up now!

@SergioGasquez SergioGasquez force-pushed the feat/overhaul-app branch 2 times, most recently from c9f922e to af135cd Compare December 12, 2025 10:43
@SergioGasquez
Copy link
Member Author

Thanks for your continued effort here. I think this is looking great!

Thank you for all the feedback and input during this long review process!

@MabezDev MabezDev requested review from jessebraham and removed request for jessebraham December 15, 2025 15:18
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still working on reviewing the code itself (there's lots of it 😩) but a few small comments to get started

@MabezDev MabezDev requested a review from jessebraham January 7, 2026 09:48
@MabezDev MabezDev merged commit d1abe38 into esp-rs:feat/overhaul Jan 7, 2026
6 checks passed
@SergioGasquez SergioGasquez deleted the feat/overhaul-app branch January 7, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants