Skip to content

Conversation

@ivmarkov
Copy link
Collaborator

@ivmarkov ivmarkov commented Jan 17, 2026

A small fix where the scan guard was missing this code:

let mut ot = self.activate();
let state = ot.state();

So scanning - in fact - did not work. :(

Two additional changes:

  • CI fixed. The reason Clippy complains about "Two identical if blocks" (though they look different) is that they DO become identical (both empty) when neither defmt nor log is enabled
  • Workspace. A small workspace ala "esp-mbedtls" was introduced so that fmt, clippy, quick rebuild etc. works from the root of the project.

@ivmarkov ivmarkov marked this pull request as ready for review January 17, 2026 14:40
@ivmarkov ivmarkov requested a review from bjoernQ January 17, 2026 14:41
Fix CI

Implement a simple workspace combining openthread-sys and openthread
Copy link
Collaborator

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivmarkov ivmarkov merged commit db09255 into esp-rs:main Jan 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants