Performance improvements + line break fix#592
Merged
balloob merged 1 commit intoesphome:mainfrom May 10, 2025
Merged
Conversation
Member
Author
|
@balloob done |
|
Out of curiosity, what caused #545 ? |
Member
Author
Previously if the device was logging at a decently fast rate the code got stuck reading serial + adding/logging lines. The call stack never returned as logging was so slow that serial data backed up looping forever. Now all serial date is buffered, the call stack returns and only then are the new lines logged. I am not 100% sure this is what caused your issue but it did cause crashes for me. Reopen if you still experience issues. |
|
I witnessed the crashes immediately when flashing ended. Before the application got to run. It was really immediate. Would this align with the logging case you describe (maybe due to boatloads logs)? |
Member
Author
|
Maybe? Hard to say. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.