Skip to content

Performance improvements + line break fix #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2025

Conversation

swoboda1337
Copy link
Contributor

@swoboda1337 swoboda1337 commented May 7, 2025

@swoboda1337 swoboda1337 changed the title Performance improvements/fixes Performance improvements + fixes May 7, 2025
@swoboda1337 swoboda1337 changed the title Performance improvements + fixes Performance improvements + line break fixe May 7, 2025
@swoboda1337 swoboda1337 changed the title Performance improvements + line break fixe Performance improvements + line break fix May 7, 2025
@swoboda1337
Copy link
Contributor Author

@balloob done

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@balloob balloob merged commit bcaf930 into esphome:main May 10, 2025
1 check passed
@yanshay
Copy link

yanshay commented May 10, 2025

Out of curiosity, what caused #545 ?

@swoboda1337
Copy link
Contributor Author

Out of curiosity, what caused #545 ?

Previously if the device was logging at a decently fast rate the code got stuck reading serial + adding/logging lines. The call stack never returned as logging was so slow that serial data backed up looping forever. Now all serial date is buffered, the call stack returns and only then are the new lines logged. I am not 100% sure this is what caused your issue but it did cause crashes for me. Reopen if you still experience issues.

@yanshay
Copy link

yanshay commented May 10, 2025

I witnessed the crashes immediately when flashing ended. Before the application got to run. It was really immediate.

Would this align with the logging case you describe (maybe due to boatloads logs)?

@swoboda1337
Copy link
Contributor Author

Maybe? Hard to say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chrome and Edge crash with esp-web-tools (including the demo) Improv works but serial log does not
3 participants