Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daly H/K/M/S-Series BMS integration #4296

Open
wants to merge 10 commits into
base: next
Choose a base branch
from

Conversation

patagonaa
Copy link

Description:

Adds documentation for the integration of the communication protocol that the new Daly BMS are using.

Related issue (if applicable):

Pull request in esphome with YAML changes (if applicable): esphome/esphome#7524

Checklist:

  • I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • Link added in /index.rst when creating new documents for new components or cookbook.

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit 4f43f00
🔍 Latest deploy log https://app.netlify.com/sites/esphome/deploys/67325743780aa90008bb07c2
😎 Deploy Preview https://deploy-preview-4296--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@patagonaa
Copy link
Author

patagonaa commented Oct 2, 2024

TODO (for me):

  • fix lint issues
  • fill/remove section about controlling the BMS
  • replace BMS picture with one that actually has UART (the current one is not a "smart" BMS)

@patagonaa patagonaa marked this pull request as ready for review October 10, 2024 18:18
@felipecrs
Copy link

felipecrs commented Oct 28, 2024

@patagonaa, as an ESPHome user and owner of a K-Series Daly BMS, I am very grateful for your PR.

I have just ordered a micro USB to pins adapter. As soon as it arrives, I will test it. :)

@felipecrs
Copy link

Related to this PR: https://github.com/syssi/esphome-daly-bms (modbus-example.yaml).

@patagonaa
Copy link
Author

@felipecrs Thanks for the kind words, I appreciate it.

You want to use the Micro-USB to pins adapter to use the cable of the Bluetooth dongle, right?
On my BMS, the Bluetooth dongle seems to be molded directly around the Micro-USB plug (if there even is one) so it can't be unplugged (unlike the "old" DALY Bluetooth dongles), better check that if you haven't already 😅.

I instead bought a set of JST-GH housings and pre-crimped wires with GH-contacts to avoid the hassle of crimping them myself (I first tried that, but it didn't work with the crimping tool I have, you'll definitely need the (expensive) crimping tool for this exact contact type or it won't work).

Initially, for testing I used an RS485 converter and the pre-crimped cable for the RS485/CAN connector included with the BMS.

@felipecrs
Copy link

Yes, I already have my K series Daly BMS, and mine has the detachable cable on both ends.

BMS BT/WIFI module
20241029_102037 image

components/sensor/daly_hkms_bms.rst Outdated Show resolved Hide resolved
components/sensor/daly_hkms_bms.rst Outdated Show resolved Hide resolved
components/sensor/daly_hkms_bms.rst Outdated Show resolved Hide resolved
@felipecrs
Copy link

I'm trying your PR finally. These are the first little issues I found.

patagonaa and others added 2 commits November 10, 2024 22:11
fix some oversights when adapting daly bms docs

Co-authored-by: Felipe Santos <[email protected]>
Connect BMS RX to ESP TX, BMS TX to ESP RX and BMS GND to ESP GND.

Alternatively, use an RS485 converter and connect A to A/+ and B to B/-.
Always connect the ground, even when using RS485, to avoid stray currents running through the RS485 transceivers.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After your refactor, I think my suggestion no longer makes sense. This reverts it:

Suggested change
Always connect the ground, even when using RS485, to avoid stray currents running through the RS485 transceivers.
Always connect the ground when using RS485 to avoid stray currents running through the RS485 transceivers.

Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 11, 2025
@patagonaa
Copy link
Author

patagonaa commented Jan 11, 2025

For christ's sake, and I thought stale bot was already terrible for issues.
Maybe a stale bot for PRs is a bad idea for a repo with (apparently) not enough reviewers to review them before they go stale.

@ssieb ssieb added not-stale and removed stale labels Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants