-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daly H/K/M/S-Series BMS integration #4296
base: next
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
TODO (for me):
|
@patagonaa, as an ESPHome user and owner of a K-Series Daly BMS, I am very grateful for your PR. I have just ordered a micro USB to pins adapter. As soon as it arrives, I will test it. :) |
Related to this PR: https://github.com/syssi/esphome-daly-bms (modbus-example.yaml). |
@felipecrs Thanks for the kind words, I appreciate it. You want to use the Micro-USB to pins adapter to use the cable of the Bluetooth dongle, right? I instead bought a set of JST-GH housings and pre-crimped wires with GH-contacts to avoid the hassle of crimping them myself (I first tried that, but it didn't work with the crimping tool I have, you'll definitely need the (expensive) crimping tool for this exact contact type or it won't work). Initially, for testing I used an RS485 converter and the pre-crimped cable for the RS485/CAN connector included with the BMS. |
I'm trying your PR finally. These are the first little issues I found. |
fix some oversights when adapting daly bms docs Co-authored-by: Felipe Santos <[email protected]>
Connect BMS RX to ESP TX, BMS TX to ESP RX and BMS GND to ESP GND. | ||
|
||
Alternatively, use an RS485 converter and connect A to A/+ and B to B/-. | ||
Always connect the ground, even when using RS485, to avoid stray currents running through the RS485 transceivers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After your refactor, I think my suggestion no longer makes sense. This reverts it:
Always connect the ground, even when using RS485, to avoid stray currents running through the RS485 transceivers. | |
Always connect the ground when using RS485 to avoid stray currents running through the RS485 transceivers. |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
For christ's sake, and I thought stale bot was already terrible for issues. |
Description:
Adds documentation for the integration of the communication protocol that the new Daly BMS are using.
Related issue (if applicable):
Pull request in esphome with YAML changes (if applicable): esphome/esphome#7524
Checklist:
I am merging into
next
because this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
current
because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/index.rst
when creating new documents for new components or cookbook.