add/change configuration variables for SPI-based Ethernet polling mode (#7503) #4285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
slakichi
force-pushed
the
pr7503-spi-ethernet-polling
branch
from
1b090f4 to
dda76a6
Compare
slakichi
force-pushed
the
pr7503-spi-ethernet-polling
branch
from
dda76a6 to
b51c280
Compare
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Fixed the link to the datasheet
|
Sorry, I merged the wrong branch in commit f6314ce; and I need to rewrite to change the behavior when both interrupt_pin and polling_interval are present in a config file (polling_interval is no longer silently ignored). Closing this PR and I will submit another PR after I rewrite. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When adding support polling mode for SPI-based Ethernet, polling interval can be configuable.
And if framework does not support polling mode,
interrupt_pinis required (by framework - so that config validator also will change behavior).Related issue (if applicable): none
Pull request in esphome with YAML changes (if applicable): esphome/esphome#7503
Checklist:
I am merging into
nextbecause this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
currentbecause this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/index.rstwhen creating new documents for new components or cookbook.