Build docker image on PRs that touch the docker files #4374
Conversation
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
WalkthroughThe pull request modifies the Docker workflow configuration in Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant GitHub
participant Workflow
participant DockerHub
participant GCR
User->>GitHub: Create Pull Request
GitHub->>Workflow: Trigger Workflow
Workflow->>DockerHub: Check if login needed
alt Not a Pull Request
Workflow->>DockerHub: Login
Workflow->>GCR: Login
Workflow->>DockerHub: Build and Push Image
else Pull Request
Workflow->>DockerHub: Skip Login
Workflow->>GCR: Skip Login
Workflow->>DockerHub: Skip Push
end
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
.github/workflows/docker.yml (1)
60-60: LGTM! Consider optimizing build cache configuration.The conditional push configuration correctly prevents pushing images from PR builds.
Consider expanding the cache-from configuration to use both registries for better cache hit rates:
- cache-from: ghcr.io/esphome/esphome-docs:latest + cache-from: | + ghcr.io/esphome/esphome-docs:latest + esphome/esphome-docs:latest
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- .github/workflows/docker.yml (3 hunks)
🧰 Additional context used
🔇 Additional comments (3)
.github/workflows/docker.yml (3)
12-16: LGTM! Well-structured trigger configuration.The pull request trigger is correctly configured with appropriate path filters that match the existing push trigger paths, ensuring consistent workflow execution.
42-42: LGTM! Good security practice.Skipping DockerHub login during pull requests is a good security measure as it prevents potential exposure of credentials in PR builds.
48-48: LGTM! Consistent security implementation.The condition matches the DockerHub login security measure, maintaining consistent security practices across different registries.
Description:
Related issue (if applicable): fixes
Pull request in esphome with YAML changes (if applicable): esphome/esphome#
Checklist:
I am merging into
nextbecause this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
currentbecause this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/index.rstwhen creating new documents for new components or cookbook.