-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix description of accuracy_decimals
#4494
base: current
Are you sure you want to change the base?
Conversation
WalkthroughThe pull request updates the documentation for the Sensor Component in ESPHome, specifically in the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
components/sensor/index.rst
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
components/sensor/index.rst (1)
Pattern **
: - Do not generate or add any sequence diagrams
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Looking into this a bit more: it is technically true that |
Description:
Related issue (if applicable): fixes #2164
The description introduced in #2164 doesn't make sense: it says that the
accuracy_decimals
setting both controls and doesn't control the number of decimals to use when reporting values.This setting plainly DOES impact the actual value reported to Home Assistant. It also controls the default display precision of the Home Assistant entity, but I do not believe this is a very important information in this context. In the interest of simplicity, I suggest we just remove the second sentence.
Checklist:
current
because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.